I can put up with a harsh tone of the original message and don’t expect users to read the code.
Double-checking that secure deletion still works after recent attempts to move to sqlx
implementation of SQLite interface and following refactoring was not a bad idea, would be bad if it was broken in the process.
First “issue” is not a security issue from my point of view and I have no idea if users expect messages to be deleted on the server. It is easy to make “delete chat” to also delete messages, but it is a destructive operation and it’s very likely other users will complain then they clicked a single button and DC deleted months of backlog from the server.
As for third point, I still think local encryption is not worth it and should be done on the operating system level. However, there is a relevant issue about encrypting backups:
As over-the-network secure transfer is planned but not implemented yet (only the first step of moving to streamable tar backup format is done) and may not work when your devices use different networks, such as your local LAN, cellular network, VPNs etc., I think it’s important to have encrypted backups.