What does "Dismiss" button on notifications do?

r10s · September 17, 2024, 2:13pm

i created two pr to solve this issue:

github.com/deltachat/deltachat-android

'Mark Read' instead 'Dismiss' notifications

deltachat:main ← deltachat:r10s/tweak-notify-dismiss

opened 02:06PM - 17 Sep 24 UTC

r10s

+3 -2

'Dismiss' is a bit unclear - even though introduced at #2083 to make things clea…rer, i do not think this has happened :) - i also needed to dive into the source code to see what exactly 'Dismiss' is doing. meanwhile, we're anyway using 'Mark Read' to remove unread counter from chats, and this is basically the same. good to be consistent. finally, this is also the term WhatsApp/Telegram are using. closes https://support.delta.chat/t/what-does-dismiss-button-on-notifications-do/3261/3 <img width=350 src=https://github.com/user-attachments/assets/d937ef6c-6d3a-43bf-8b4b-89c51e03afbe> nb: we also change the english 'short' term from 'Read' to 'Mark Read' - this is sill shorter than many translations and removes the ambiguousness 'Mark Read' vs 'Open for Reading" - esp. in the notification without much context, this is better, but also on iOS, where the term was introduced for, it is good to be explict.

github.com/deltachat/deltachat-android

marked chat replied to as being noticed

deltachat:main ← deltachat:r10s/mark-replied-chat-noticed

opened 02:16PM - 17 Sep 24 UTC

r10s

+1 -0

when replying from within a notification, the corresponding chat should be mark…ed as being noticed as well. otherwise, it looks wrong that one has replied to a chat, but still the chat is shown as being "unread". the 'reply' from a notification should leave the chat in the same state as 'dismiss' resp. 'mark read' - plus the added message.